fix: remove icon_url from url source block element and plan_id from plan block and update chat stream variable#1822
Conversation
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat-ai-apps-thinking-steps #1822 +/- ##
==============================================================
Coverage ? 83.96%
==============================================================
Files ? 116
Lines ? 13221
Branches ? 0
==============================================================
Hits ? 11101
Misses ? 2120
Partials ? 0 ☔ View full report in Codecov by Sentry. |
zimeg
changed the title
| async def _flush_buffer(self, chunks: Optional[Sequence[Union[Dict, Chunk]]] = None, **kwargs) -> AsyncSlackResponse: | ||
| """Flush the internal buffer with chunks by making appropriate API calls.""" | ||
| flushings: List[Union[Dict, Chunk]] = [] | ||
| chunks_to_flush: List[Union[Dict, Chunk]] = [] |
There was a problem hiding this comment.
This is a much better name choice and it adds clarity around what will be flushed.
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Great work! A nice clean removal of icon_url and plan_id. The refactor to chunks_to_flush also makes the code more readable.
📝 Just a note for our future selves - icon_url and plan_id are internal properties that aren't available on the public API yet. So, there are no breaking changes.
🧪 Test coverage looks great and this has no impact on our sample app. 🚀
| async def _flush_buffer(self, chunks: Optional[Sequence[Union[Dict, Chunk]]] = None, **kwargs) -> AsyncSlackResponse: | ||
| """Flush the internal buffer with chunks by making appropriate API calls.""" | ||
| flushings: List[Union[Dict, Chunk]] = [] | ||
| chunks_to_flush: List[Union[Dict, Chunk]] = [] |
There was a problem hiding this comment.
This is a much better name choice and it adds clarity around what will be flushed.
3 participants
Summary
This PR removes the
icon_urlfrom theurlsource block element to match the expected API and also updates an internalchat_streamvariable for maintenance ongoing.The
plan_idis also removed from the plan block.Testing
Build these changes and stream a message with this app:
Category
/docs(Documents)tests/integration_tests(Automated tests for this library)Notes
No update was made for an
appendwithout either "chunks" or "markdown_text" following discussion of #1809. With logging set to "debug" we might find an alright hint that the buffer is unchanged:Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.